Skip to content

patterns: don't ice when encountering a raw str slice #117807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2023
Merged

patterns: don't ice when encountering a raw str slice #117807

merged 1 commit into from
Nov 19, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 11, 2023 •
edited
Loading

Fixes #117806

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2023
@RalfJung RalfJung mentioned this pull request Nov 11, 2023
Closed
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

📌 Commit f6a49ba has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2023
@davidtwco
Copy link
Member

@bors rollup

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

⌛ Testing commit f6a49ba with merge d0474fb...

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing d0474fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2023
@bors bors merged commit d0474fb into rust-lang:master Nov 19, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 19, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d0474fb): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 -4.9% [-4.9%, -4.9%] 1
Improvements ✅
(secondary)		 -4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) -4.9% [-4.9%, -4.9%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.8% [2.3%, 3.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.69s -> 676.64s (0.29%)
Artifact size: 313.81 MiB -> 313.81 MiB (-0.00%)

@RalfJung RalfJung deleted the raw-str-slice branch November 20, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

ICE: Got a scalar pair where a scalar was expected
6 participants
@RalfJung @rustbot @davidtwco @bors @rust-timer @matthiaskrgr